Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO extra columns show with use consumption data pref #6020

Open
wants to merge 1 commit into
base: V2.5.0-RC
Choose a base branch
from

Conversation

roxy-dao
Copy link
Contributor

Fixes #6019

πŸ‘©πŸ»β€πŸ’» What does this PR do?

From specs

Note that the new columns have already been added to program based requisitions.
Implement the store permissions for
Keep requisition lines with zero requested quantity on finalise
Use consumption and clients stock data in internal orders

Showing extra columns only if the user has the use consumption data pref turned on.

πŸ§ͺ Testing

  • Have use consumption data pref off
  • Create a program IO
  • Don't see extra columns
  • Turn pref on
  • Create program IO
  • See extra columns

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the V2.5.0-RC3 milestone Jan 13, 2025
@github-actions github-actions bot added bug Something is borken needs triage Team Ruru πŸ¦‰ Andrei, Roxy, Ferg feature: CIV labels Jan 13, 2025
Copy link

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.15 MB 5.15 MB -93 B (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken feature: CIV Team Ruru πŸ¦‰ Andrei, Roxy, Ferg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra fields in IO should use Use consumption and clients stock data in internal orders pref
2 participants